Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check for latest version of Uno.Check #124

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Conversation

MartinZikmund
Copy link
Member

No description provided.

@MartinZikmund MartinZikmund self-assigned this Jan 20, 2023
@MartinZikmund
Copy link
Member Author

@jeromelaban Noticed now there is a "required version" check in ToolInfo.Validate which checks against required version from manifest, but maybe this approach is better as it will always point to the latest version, so it could replace/complement the existing one, right?

@jeromelaban
Copy link
Member

@jeromelaban Noticed now there is a "required version" check in ToolInfo.Validate which checks against required version from manifest, but maybe this approach is better as it will always point to the latest version, so it could replace/complement the existing one, right?

Required version is useful when manifests are explicitly provided, but that's not something end-users will use. Your approach addresses another need, as it pokes at the latest on the feed. Thanks!

# Conflicts:
#	UnoCheck/CheckCommand.cs
@jeromelaban jeromelaban merged commit dadca15 into main Feb 10, 2023
@jeromelaban jeromelaban deleted the dev/mazi/version-check branch February 10, 2023 14:14
@jeromelaban jeromelaban mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants